Hi I need some help/guides on how to Fetch and build the PR-4585 for NIFI-7863 so I can build it and test it.
I have created a new VM with Ubuntu 20. Installed Maven, GIT and Java. I used GIT to sync the git-wip-us.apache.org/repos/asf/nifi.git I tried to make a full build, but 2 NAR's failed. I went into the folder for the SMB processors, and build the NAR for that specific folder which works. I copied the new NAR file to my NIFI server for testing the new processor, but I can see it does not include the change made for the PR Kind regards Jens M. Kofoed Den man. 22. mar. 2021 kl. 20.03 skrev Jens M. Kofoed < jmkofoed....@gmail.com>: > Dear Mark > > I would love to help, testing the PR to check that it is working. My only > problem is I'm not able to build the nar files my self. So if someone can > build the file, I have no problems testing the file. > > About SMB: > I don't like to mount networks drives locally to my NiFi servers which is > running Linux. For accessing linux servers I am using SFTP, the big issue > are with Windows servers and those who administrate them. They like so use > Windows shares, and use AD access rights. I have tried to setup a NFS share > in Windows server 2019, but it was not easy to get it to work and > diffidently not then we had to make changes. So i order to get access to > Windows servers, I have configured MS IIS with a FTP Site. > To be able to use smb shares, I hope it would be much easier. > > kind regards > Jens M. Kofoed > > > > Den man. 22. mar. 2021 kl. 19.19 skrev Joe Witt <joe.w...@gmail.com>: > >> pretty sure SMB is super popular - it is just that for the cases we >> typically engage in SMB isn't used as the protocol to access data :) >> >> Agree with the rest of that >> >> Thanks >> >> On Mon, Mar 22, 2021 at 11:13 AM Mark Payne <marka...@hotmail.com> wrote: >> > >> > Jens, >> > >> > In order to review & merge a PR, there are two important things that >> need to happen: >> > >> > 1. A NiFi committer must review the code to make sure that the changes >> are safe, make sense, conducive with the architecture, is adhering to best >> practices, doesn’t break automated tests, etc. >> > 2. The code needs to be tested - typically this is accomplished both >> manually and in an automated sense. Sometimes only manually, sometimes >> automated. >> > >> > For this case, we really would need someone other than the contributor >> who put up the PR to test this manually to verify that it works. The >> problem is that SMB isn’t really that popular, I don’t think. So we would >> need someone who can verify that the changes work as desired. This doesn’t >> need to be a committer. >> > >> > If you’re able to build that branch and verify the changes and then >> report back any positive or negative findings, that can go a long way to >> help in the review process. >> > >> > Thanks >> > -Mark >> > >> > On Mar 22, 2021, at 4:03 AM, Jens M. Kofoed <jmkofoed....@gmail.com> >> wrote: >> > >> > Hi >> > >> > The following JIRA: https://issues.apache.org/jira/browse/NIFI-7863, >> was created October 1, 2020 and the user Jaya has created a PR October 9, >> 2020. but nothing have happens since. >> > >> > Are there someone in the community which is able to help implement a >> fix? >> > We had looked forward to see the fix included in 1.13, but >> unfortunately it is not. >> > >> > Kind regards >> > Jens M. Kofoed >> > >> > >> > >> > >> >
