Hi Mark I'm using NiFi version 1.13.2 and I have fetched the main branch from git version 1.14.0-SNAPSHOT. I went into the folder nifi-nar-bundles/nifi-smb-bundle/ and executed the command: mvn -T C2.0 clean install -Ddir-only I copied the newly created NAR file in the nifi-smb-nar/target directory (can't remember the full path) and saved it in /opt/nifi/nifi-current/extension folder
After a minutes or two I added a new processor to the canvas. In the Processor dialog window I could see 2 PutSMBFile processors. A 1.13.2 version and a 1.14.0-SNAPSHOT version. I added the 1.14.0-SNAPSHOT to the canvas to test it. But it still doesn't create missing recursive directories. Now I would like to test the fix jayaaditya <https://github.com/jayaaditya> made in https://github.com/apache/nifi/pull/4585/files fixing the reported issue in https://issues.apache.org/jira/projects/NIFI/issues/NIFI-7863 I'm very new to git and maven, but writes C# and pythons so after trying to figure out how to fetch the PR I manually changed the java files on my computer and tried to make a new build. But unfortunately it still not working. I didn't see any errors messages like you describe. But after updating the nar file in the extension folder and restarting NiFi I could see information about the 1.14.0-SNAPSHOTnar files was changes and it loaded the new version. So I would be very very grateful for any help. I have to distribute files to many different Windows servers and my Windows Administrators hates to setup new ftp services every time a new server comes in place. So the PutSMB processor is very much needed. Next are some minor changes to the GetSMB ( https://issues.apache.org/jira/projects/NIFI/issues/NIFI-7908) which I will try to see if I can fix. Kind regards Jens M. Kofoed Den tir. 20. apr. 2021 kl. 15.26 skrev Mark Payne <[email protected]>: > Jens, > > What version of NiFi did you deploy it to? What is the version of the > processor that you built? My guess, given what I’ve read here is that you > built the car and copied it over but then created an instance of the > Processor using the old version of the NAR. > > Would recommend you remove the version of the NAR that was previously > there. For example, maybe you have a 1.13.2 version and a 1.14.0-SNAPSHOT > version that you built. Remove the 1.13.2 version from the lib/ directory > and restart. There are other ways to handle this by changing the version of > the processor, etc. but this is probably the easiest route if just > verifying the changes. > > I’d also recommend gripping the logs for the line "Successfully created > class loaders” and see if there are any NAR’s that were skipped. For > example, do you see something like: > > Successfully created class loaders for 109 NARs, 1 were skipped > > That would indicate that it did not properly load the NAR, because it has > a dependency on another NAR, and it couldn’t find that dependency. > > Thanks > -Mark > > > > > On Apr 20, 2021, at 2:20 AM, Jens M. Kofoed <[email protected]> > wrote: > > > > Hi > > > > I need some help/guides on how to Fetch and build the PR-4585 for > NIFI-7863 so I can build it and test it. > > > > I have created a new VM with Ubuntu 20. Installed Maven, GIT and Java. > > I used GIT to sync the git-wip-us.apache.org/repos/asf/nifi.git > > I tried to make a full build, but 2 NAR's failed. > > > > I went into the folder for the SMB processors, and build the NAR for > that specific folder which works. > > I copied the new NAR file to my NIFI server for testing the new > processor, but I can see it does not include the change made for the PR > > > > Kind regards > > Jens M. Kofoed > > > > > > Den man. 22. mar. 2021 kl. 20.03 skrev Jens M. Kofoed < > [email protected]>: > > Dear Mark > > > > I would love to help, testing the PR to check that it is working. My > only problem is I'm not able to build the nar files my self. So if someone > can build the file, I have no problems testing the file. > > > > About SMB: > > I don't like to mount networks drives locally to my NiFi servers which > is running Linux. For accessing linux servers I am using SFTP, the big > issue are with Windows servers and those who administrate them. They like > so use Windows shares, and use AD access rights. I have tried to setup a > NFS share in Windows server 2019, but it was not easy to get it to work and > diffidently not then we had to make changes. So i order to get access to > Windows servers, I have configured MS IIS with a FTP Site. > > To be able to use smb shares, I hope it would be much easier. > > > > kind regards > > Jens M. Kofoed > > > > > > > > Den man. 22. mar. 2021 kl. 19.19 skrev Joe Witt <[email protected]>: > > pretty sure SMB is super popular - it is just that for the cases we > > typically engage in SMB isn't used as the protocol to access data :) > > > > Agree with the rest of that > > > > Thanks > > > > On Mon, Mar 22, 2021 at 11:13 AM Mark Payne <[email protected]> > wrote: > > > > > > Jens, > > > > > > In order to review & merge a PR, there are two important things that > need to happen: > > > > > > 1. A NiFi committer must review the code to make sure that the changes > are safe, make sense, conducive with the architecture, is adhering to best > practices, doesn’t break automated tests, etc. > > > 2. The code needs to be tested - typically this is accomplished both > manually and in an automated sense. Sometimes only manually, sometimes > automated. > > > > > > For this case, we really would need someone other than the contributor > who put up the PR to test this manually to verify that it works. The > problem is that SMB isn’t really that popular, I don’t think. So we would > need someone who can verify that the changes work as desired. This doesn’t > need to be a committer. > > > > > > If you’re able to build that branch and verify the changes and then > report back any positive or negative findings, that can go a long way to > help in the review process. > > > > > > Thanks > > > -Mark > > > > > > On Mar 22, 2021, at 4:03 AM, Jens M. Kofoed <[email protected]> > wrote: > > > > > > Hi > > > > > > The following JIRA: https://issues.apache.org/jira/browse/NIFI-7863, > was created October 1, 2020 and the user Jaya has created a PR October 9, > 2020. but nothing have happens since. > > > > > > Are there someone in the community which is able to help implement a > fix? > > > We had looked forward to see the fix included in 1.13, but > unfortunately it is not. > > > > > > Kind regards > > > Jens M. Kofoed > > > > > > > > > > > > > >
