Hi,
Here is an example of the produced markup for an single INFO message:
<div id="feedbackPanel">
<span>
<ul class="feedbackPanel">
<li class="feedbackPanelINFO">
<span class="feedbackPanelINFO">Saved model [TestInputObject
stringProperty = 'test', integerProperty = 100, doubleProperty = 20.5,
booleanProperty = false, integerInRangeProperty = 50, urlProperty =
http://wicket.apache.org, phoneNumberUS = (123) 456-1234,
numberRadioChoice = 1, numbersCheckgroup [], numberRadioGroup= null,
selected sites {], lines [line one, line two, line three]]</span>
</li>
</ul>
</span>
</div>
Why do we need the new getters when you can just use normal CSS selectors:
div.feedbackPanel {}
div.feedbackPanel span {}
ul.feedbackPanel {}
li.feedbackPanelINFO {}
span.feedbackPanelINFO {}
What is the big CSS/HTML design problem that I miss ?
On Thu, Oct 25, 2012 at 2:07 AM, Joachim Schrod <jsch...@acm.org> wrote:
> Paul Bors wrote:
>> Yes, but how would that affect other projects that do expect the CSS to be
>> applied to the LI or SPAN?
>> Come to think about it, I could very simple replace the content of both with
>> my own panels right?
>>
>> I think this is a project specific requirement
>
> I just want to add my voice that it's not a project specific
> requirement, but a sound design change that resolves a design bug.
>
> That a CSS class applies both to LI and to below-SPAN element, is
> clearly not appropriate for almost all situations. The proposed
> change even keeps that, for backward-compatibility.
>
> Of course, one can subclass FeedbackPanel and sustitute the HTML
> code. We do it in all projects. But this is a workaround for a bug
> in Wicket's HTML/CSS/interface design, and not a to-be-continued asset.
>
> Just my 0.03€ (adjusted for inflation),
> Joachim
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org
