I like it! First round of comments.
https://codereview.chromium.org/391413006/diff/20001/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/391413006/diff/20001/src/globals.h#newcode361
src/globals.h:361: enum GarbageCollector { SCAVENGER = 0, MARK_COMPACTOR
= 1};
Why do you have to initialize it with =0, and =1?
https://codereview.chromium.org/391413006/diff/20001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/391413006/diff/20001/src/heap.cc#newcode6022
src/heap.cc:6022: Event mark_compactor_dummy_event(MARK_COMPACTOR, NULL,
NULL);
Hmm, I am not sure if the dummy elements may be problematic. What about
calculating the average gc time of the events in a buffer. The dummy
element would have an impact on that.
https://codereview.chromium.org/391413006/diff/20001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/391413006/diff/20001/src/heap.h#newcode653
src/heap.h:653: struct Event {
C++ style guide: Use a struct only for passive objects that carry data;
everything else is a class.
https://codereview.chromium.org/391413006/diff/20001/src/heap.h#newcode749
src/heap.h:749: EventBuffer event_buffers_[2];
Ah, now I see why you have to initialize the enum. Why don't we use two
EventBuffer intances?
EventBuffer scavenber_buffer_;
EventBuffer mark_compact_buffer_;
Should actually result in more compact code. WDYT? However, I can live
with both options.
https://codereview.chromium.org/391413006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
