https://codereview.chromium.org/391413006/diff/40001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/391413006/diff/40001/src/heap.h#newcode607
src/heap.h:607: end_ = (end_ + 1) % (MAX_SIZE + 1);
Ahm, yes. I guess we could also use a counter. But I am fine with what
you have.
The counter could be used to distinguish empty from full cases. The
tricky part is the iterators. With one extra slot we can always point
the end iterator to an empty slot.
But, I am not really convinced that we should have an anchor element.
It counts
as a real element, i.e., you would have to add special handling left
and right o
filter out the element. Wouldn't it be just simpler to handle the
empty case.
The current version explicitly tracks the current, previous and
previous_mark_compactor events on GCTracer (outside of the ring
buffers). The tracked events are initialized with a special START event
that records the statistics at construction time. The rest of the code
handles the case of insufficient event counts in a completely
transparent way.
https://codereview.chromium.org/391413006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
