https://codereview.chromium.org/391413006/diff/40001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/391413006/diff/40001/src/heap.cc#newcode5974
src/heap.cc:5974: GCTracer::Event::Event()
Why do we need the default constructor?
https://codereview.chromium.org/391413006/diff/40001/src/heap.cc#newcode6059
src/heap.cc:6059: if (collector == SCAVENGER)
coding style: if/else likes curly braces
https://codereview.chromium.org/391413006/diff/40001/src/heap.cc#newcode6088
src/heap.cc:6088: scavenger_events_.push_back(pending_);
coding style: if/else likes curly braces
https://codereview.chromium.org/391413006/diff/40001/src/heap.cc#newcode6130
src/heap.cc:6130: mark_compactor_events_.back()->end_time)
coding style: if/else likes curly braces
https://codereview.chromium.org/391413006/diff/40001/src/heap.cc#newcode6159
src/heap.cc:6159: return last_in_other_buffer;
coding style: if/else likes curly braces
https://codereview.chromium.org/391413006/diff/40001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/391413006/diff/40001/src/heap.h#newcode607
src/heap.h:607: end_ = (end_ + 1) % (MAX_SIZE + 1);
Hmm, MAX_SIZE+1 makes the code really complicated. And, the anchor
elements is just there until it gets overwritten (logically it is still
there after that). I am wondering if it wouldn't be cleaner if we would
handle the case where there is no previous element externally... WDYT?
https://codereview.chromium.org/391413006/diff/40001/src/heap.h#newcode615
src/heap.h:615: size_t end_;
DISALLOW_COPY_AND_ASSIGN
https://codereview.chromium.org/391413006/diff/40001/src/heap.h#newcode676
src/heap.h:676: INVALID = 3
what is the purpose of invalid?
https://codereview.chromium.org/391413006/diff/40001/test/cctest/cctest.gyp
File test/cctest/cctest.gyp (right):
https://codereview.chromium.org/391413006/diff/40001/test/cctest/cctest.gyp#newcode81
test/cctest/cctest.gyp:81: 'test-gc-tracer.cc',
awesome!
https://codereview.chromium.org/391413006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
