https://codereview.chromium.org/1291693004/diff/180001/src/compiler/bytecode-graph-builder.cc
File src/compiler/bytecode-graph-builder.cc (right):
https://codereview.chromium.org/1291693004/diff/180001/src/compiler/bytecode-graph-builder.cc#newcode46
src/compiler/bytecode-graph-builder.cc:46: const Operator* receiver_op =
common()->Parameter(-1, nullptr);
On 2015/09/07 08:40:15, oth wrote:
On 2015/09/04 16:46:58, Michael Starzinger wrote:
> Something is highly fishy here. Parameter(0) should refer to the
receiver.
> Essentially if you call "x.f(a,b,c)", then ...
>
> Parameter(0) == x // Receiver
> Parameter(1) == a // 1st arg
> Parameter(2) == b // 2nd arg
> Parameter(3) == c // 3rd arg
> Parameter(4) == f.context // Context
> Parameter(-1) == f // Closure
>
> Anything else would surprise me if it'd work.
Right, I think we got confused by the wording of the comment in
ast-graph-builder and lost our way. Hopefully moved back closer this
in last
upload.
Looks good now.
https://codereview.chromium.org/1291693004/diff/200001/src/compiler/bytecode-graph-builder.cc
File src/compiler/bytecode-graph-builder.cc (right):
https://codereview.chromium.org/1291693004/diff/200001/src/compiler/bytecode-graph-builder.cc#newcode65
src/compiler/bytecode-graph-builder.cc:65: return parameter_index;
nit: Just "return the_register.ToParameterIndex(parameter_count())"
here?
https://codereview.chromium.org/1291693004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
