Looks great, let's land it!
https://codereview.chromium.org/1291693004/diff/260001/src/interpreter/bytecode-array-iterator.cc
File src/interpreter/bytecode-array-iterator.cc (right):
https://codereview.chromium.org/1291693004/diff/260001/src/interpreter/bytecode-array-iterator.cc#newcode67
src/interpreter/bytecode-array-iterator.cc:67: return
FixedArray::get(constants, GetIndexOperand(operand_index));
On 2015/09/10 13:59:06, oth wrote:
On 2015/09/10 10:19:43, rmcilroy wrote:
> this should be "constants->get(GetIndexOperand(operand_index));" I
think.
The static version returns a handle for the element that this method
returns.
The member version returns bare object pointer. The current path might
be
cleaner than cons-ing up handle here. WDYT?
Ahh you're right sorry. Strange that this is a static method though...
but not your problem :).
https://codereview.chromium.org/1291693004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
