Looking good. Some minor comments. Additionally, please disambiguate between
codes (encodings) and code (either code, code objects or code group).
https://chromiumcodereview.appspot.com/12225099/diff/6010/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://chromiumcodereview.appspot.com/12225099/diff/6010/src/ia32/lithium-codegen-ia32.cc#newcode5342
src/ia32/lithium-codegen-ia32.cc:5342: }
Is there a reason you copy the maps list, rather than just storing the
pointer?
https://chromiumcodereview.appspot.com/12225099/diff/6010/src/ia32/lithium-codegen-ia32.cc#newcode5343
src/ia32/lithium-codegen-ia32.cc:5343: __ LoadHeapObject(reg,
prototypes->at(prototypes->length() - 1));
Do all clients depend on this object being loaded? If not, we may want
to look into a way to remove this load as well. Perhaps in a different
CL though.
https://chromiumcodereview.appspot.com/12225099/diff/6010/src/objects.h
File src/objects.h (right):
https://chromiumcodereview.appspot.com/12225099/diff/6010/src/objects.h#newcode4710
src/objects.h:4710: // and depend on being deoptimized when map layout
changes.
Group of code that omit run-time prototype checks for prototypes
described by this map. The group is deoptimized whenever an object
described by this map changes shape (and transitions to a new map),
possibly invalidating the assumptions embedded in the code.
https://chromiumcodereview.appspot.com/12225099/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
