Thanks, I agree that removing the prototype checks on hydrogen level would
be
cleaner. I'll think about the parallel recompilation issue. For now I added
TODO
in ia32 lithium-codegen.
https://chromiumcodereview.appspot.com/12225099/diff/24002/src/mark-compact.cc
File src/mark-compact.cc (right):
https://chromiumcodereview.appspot.com/12225099/diff/24002/src/mark-compact.cc#newcode2373
src/mark-compact.cc:2373: int number_of_codes =
starts.at(DependentCode::kGroupCount);
On 2013/02/14 12:44:04, Michael Starzinger wrote:
We should definitely add a number_of_codes() helper to
GroupStartIndexes instead
of hard-coding the magic constant here.
Done.
https://chromiumcodereview.appspot.com/12225099/diff/24002/src/mark-compact.cc#newcode2390
src/mark-compact.cc:2390: int number_of_codes =
starts.at(DependentCode::kGroupCount);
On 2013/02/14 12:44:04, Michael Starzinger wrote:
Likewise.
Done.
https://chromiumcodereview.appspot.com/12225099/diff/24002/src/objects.h
File src/objects.h (right):
https://chromiumcodereview.appspot.com/12225099/diff/24002/src/objects.h#newcode4716
src/objects.h:4716: };
On 2013/02/14 12:44:04, Michael Starzinger wrote:
Add an empty newline after this enum.
Done.
https://chromiumcodereview.appspot.com/12225099/diff/24002/src/objects.h#newcode4726
src/objects.h:4726: };
On 2013/02/14 12:44:04, Michael Starzinger wrote:
Add and empty newline after this class.
Done.
https://chromiumcodereview.appspot.com/12225099/diff/24002/src/objects.h#newcode4734
src/objects.h:4734: // and the mark compactor.
On 2013/02/14 12:44:04, Michael Starzinger wrote:
s/mark compactor/mark compact collector/
Done.
https://chromiumcodereview.appspot.com/12225099/diff/24002/src/objects.h#newcode4980
src/objects.h:4980: // [dependent codes]: list of optimized codes that
have this map embedded.
On 2013/02/14 12:44:04, Michael Starzinger wrote:
The name in the comment is outdated.
Done.
https://chromiumcodereview.appspot.com/12225099/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
