LGTM with one final comment.
https://codereview.chromium.org/12225099/diff/35001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/12225099/diff/35001/src/objects.h#newcode5213
src/objects.h:5213:
Drop one of the two empty newlines.
https://codereview.chromium.org/12225099/diff/35001/src/objects.h#newcode5214
src/objects.h:5214: inline void NotifyObjectLayoutChange();
Could we rename this to "NotifyLeafMapLayoutChange()", because it only
fires if we don't have a transition. Also we definitely need a comment
above this declaration explaining when this notification fires.
https://codereview.chromium.org/12225099/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
