High-level comments: This leaves the HCheckPrototypeMaps in the graph and
turns
LCheckPrototypeMaps into a constant load under some conditions. IMHO it
would be
cleaner to actually replace the HCheckPrototypeMaps with an appropriate
HConstant (e.g. during canonicalization).
As discussed offline, this interferes with parallel recompilation, but I
still
think it would be cleaner this way. I'll think about it some more.
https://codereview.chromium.org/12225099/diff/24002/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/12225099/diff/24002/src/mark-compact.cc#newcode2373
src/mark-compact.cc:2373: int number_of_codes =
starts.at(DependentCode::kGroupCount);
We should definitely add a number_of_codes() helper to GroupStartIndexes
instead of hard-coding the magic constant here.
https://codereview.chromium.org/12225099/diff/24002/src/mark-compact.cc#newcode2390
src/mark-compact.cc:2390: int number_of_codes =
starts.at(DependentCode::kGroupCount);
Likewise.
https://codereview.chromium.org/12225099/diff/24002/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/12225099/diff/24002/src/objects.h#newcode4716
src/objects.h:4716: };
Add an empty newline after this enum.
https://codereview.chromium.org/12225099/diff/24002/src/objects.h#newcode4726
src/objects.h:4726: };
Add and empty newline after this class.
https://codereview.chromium.org/12225099/diff/24002/src/objects.h#newcode4734
src/objects.h:4734: // and the mark compactor.
s/mark compactor/mark compact collector/
https://codereview.chromium.org/12225099/diff/24002/src/objects.h#newcode4980
src/objects.h:4980: // [dependent codes]: list of optimized codes that
have this map embedded.
The name in the comment is outdated.
https://codereview.chromium.org/12225099/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
