PTAL
https://codereview.chromium.org/236143002/diff/60001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/236143002/diff/60001/src/objects.cc#newcode15918
src/objects.cc:15918: Object* undefined =
table->GetHeap()->undefined_value();
On 2014/04/14 21:25:54, adamk wrote:
Please use a Handle here (available from
isolate->factory()->undefined_value()).
Done.
https://codereview.chromium.org/236143002/diff/60001/src/objects.cc#newcode15926
src/objects.cc:15926: Object* old_iterator = table->iterators();
On 2014/04/14 21:25:54, adamk wrote:
Style-wise I'd also handl-ify this one (in case more code gets added
below that
happens to cause allocations).
Done.
https://codereview.chromium.org/236143002/diff/60001/src/objects.cc#newcode16076
src/objects.cc:16076: Object* object = iterator->table();
On 2014/04/14 21:25:54, adamk wrote:
Need to use a Handle here.
Done.
https://codereview.chromium.org/236143002/diff/60001/src/objects.cc#newcode16115
src/objects.cc:16115: OrderedHashSet* table =
OrderedHashSet::cast(iterator->table());
On 2014/04/14 21:25:54, adamk wrote:
Needs to be a Handle too.
Done.
https://codereview.chromium.org/236143002/diff/60001/src/objects.cc#newcode16145
src/objects.cc:16145: OrderedHashMap* table =
OrderedHashMap::cast(iterator->table());
On 2014/04/14 21:25:54, adamk wrote:
And this one too.
Done.
https://codereview.chromium.org/236143002/diff/60001/src/objects.cc#newcode16156
src/objects.cc:16156: Object* value = table->get(entry_index + 1);
On 2014/04/14 21:25:54, adamk wrote:
These both need to be Handles.
Done.
https://codereview.chromium.org/236143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
