lgtm from my end, but of course I'm no v8 OWNER; looking forward to what
Michael
and/or Andreas have to say.
https://codereview.chromium.org/236143002/diff/90001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/236143002/diff/90001/src/objects.cc#newcode16122
src/objects.cc:16122: Handle<Object> object(iterator->table(), isolate);
On 2014/04/15 00:29:17, arv wrote:
On 2014/04/14 22:46:38, adamk wrote:
> I don't see this used anywhere, you should be able to collapse it
into the
line
> below.
It is used on the next line.
Sorry, I mis-spoke, I meant to say the next line could instead read:
Handle<OrderedHashSet> table(OrderedHashSet::cast(iterator->table()),
isolate);
https://codereview.chromium.org/236143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
