https://codereview.chromium.org/236143002/diff/90001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/236143002/diff/90001/src/bootstrapper.cc#newcode1295
src/bootstrapper.cc:1295: if (FLAG_harmony_collections) {
Can you move those map constructions up to here?
https://codereview.chromium.org/236143002/diff/90001/src/bootstrapper.cc#newcode1400
src/bootstrapper.cc:1400: Handle<Map> map =
isolate()->factory()->NewMap(
Please move these up to their associated collections.
https://codereview.chromium.org/236143002/diff/90001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/236143002/diff/90001/src/objects.cc#newcode16023
src/objects.cc:16023: Handle<Object> undefined =
isolate->factory()->undefined_value();
Why did these get handlified? I don't see any allocation. Can this
function just get a DisallowHeapAllocation at the top?
https://codereview.chromium.org/236143002/diff/90001/src/objects.cc#newcode16056
src/objects.cc:16056: Handle<Object> object(this->table(), isolate);
Ditto down here, why all the handles?
https://codereview.chromium.org/236143002/diff/90001/src/objects.cc#newcode16107
src/objects.cc:16107: Handle<Map>
map(isolate->context()->native_context()->set_iterator_map());
You should be able to just say
isolate->set_iterator_map()
https://codereview.chromium.org/236143002/diff/90001/src/objects.cc#newcode16122
src/objects.cc:16122: Handle<Object> object(iterator->table(), isolate);
I don't see this used anywhere, you should be able to collapse it into
the line below.
https://codereview.chromium.org/236143002/diff/90001/src/objects.cc#newcode16139
src/objects.cc:16139: Handle<Map>
map(isolate->context()->native_context()->map_iterator_map());
isolate->map_iterator_map()
https://codereview.chromium.org/236143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
