On Mon, 16 Mar 2026 10:07:44 GMT, Paul Hübner <[email protected]> wrote:
>> test/hotspot/jtreg/compiler/valhalla/inlinetypes/InlineTypes.java line 41: >> >>> 39: "--add-exports", >>> "java.base/jdk.internal.vm.annotation=ALL-UNNAMED", >>> 40: "--add-exports", >>> "java.base/jdk.internal.misc=ALL-UNNAMED", >>> 41: "-XX:+UnlockDiagnosticVMOptions", >> >> Unrelated to this PR, but I saw this flag: >> "-XX:+IgnoreUnrecognizedVMOptions", >> >> I would consider removing from all the tests as a follow-up PR. We've been >> bitten by that flag so many times in our testing that we shouldn't use it at >> all, unless there's a written motivation why it is needed. My 2c. > > Fair point, seems like a very slippery slope indeed. I've filed > [JDK-8380140](https://bugs.openjdk.org/browse/JDK-8380140) for compiler since > they're the only ones who use the flag in Valhalla. Let's have them take a > look and make an informed decision. We could probably remove the from this test because all the Flattening flags are diagnostic and available in product mode. We've added -XX:+IgnoreUnrecognizedVMOptions for tests that pass develop options. I suppose if the test is trying to test the develop option there's probably a @requires vm.debug that should be on these tests instead. This could remove these I think and leave the others for another day. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2226#discussion_r2996680452
