On Thu, 26 Mar 2026 17:51:53 GMT, Coleen Phillimore <[email protected]> wrote:
>> We could probably remove the from this test because all the Flattening flags >> are diagnostic and available in product mode. We've added >> -XX:+IgnoreUnrecognizedVMOptions for tests that pass develop options. I >> suppose if the test is trying to test the develop option there's probably a >> @requires vm.debug that should be on these tests instead. >> This could remove these I think and leave the others for another day. > > Are there Experimental options, requiring adding UnlockExperimentalVMOptions ? This PR already has a large and invasive scope, I am not super comfortable changing anything that's not strictly necessary. Yes, there is lot's of cleanup that can be done (and flag duplication in some tests), but I would prefer to keep this focused on what's needed for the CSR. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2226#discussion_r2999913859
