On Wed, 22 Apr 2026 08:58:23 GMT, Paul Hübner <[email protected]> wrote:
>> Evgeny Nikitin has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove 'final' for the value classes >> - Grammar fix in comment > > test/hotspot/jtreg/testlibrary/jittester/src/jdk/test/lib/jittester/factories/AbstractKlassFactory.java > line 69: > >> 67: this.level = level; >> 68: interfaces = new ArrayList<>(); >> 69: abstractProbabilityAdjustment = 0.2; // Probability to consider >> making class an abstract > > s/an abstract/abstract Wow, an article correction. Being a linguistic freak, I highly appreciate that. Fixing indeed! > test/hotspot/jtreg/testlibrary/jittester/src/jdk/test/lib/jittester/visitors/JavaCodeVisitor.java > line 663: > >> 661: TypeKlass thisKlass = node.getThisKlass(); >> 662: String r = (ProductionParams.enableStrictFP.value() ? "strictfp >> " : "") >> 663: + (thisKlass.isFinal() ? "final " : "") > > Value classes are implicitly final unless explicitly denoted as abstract. Fixed, thanks. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2346#discussion_r3128951981 PR Review Comment: https://git.openjdk.org/valhalla/pull/2346#discussion_r3128953162
