On Wed, 22 Apr 2026 16:50:38 GMT, Evgeny Nikitin <[email protected]> wrote:
>> test/hotspot/jtreg/testlibrary/jittester/src/jdk/test/lib/jittester/visitors/ByteCodeVisitor.java
>> line 1098:
>>
>>> 1096: @Override
>>> 1097: public byte[] visit(ValueKlass node) {
>>> 1098: throw new UnsupportedOperationException("ByteCodeVisitor
>>> doesn't support Value classes");
>>
>> What are the implications of this? Is this something that's planned in a
>> follow-up?
>
> I honestly don't trust the BytecodeGenerator at all and didn't want to add
> support here. Bytecodes generated by javac for value classes do not differ
> with a single flag or something, they are different in many places. But we
> can add support in the future.
>
> Implications are following - users of the library would need to switch off
> support for value klasses in the ProductionParams when they use the
> BytecodeGenerator.
Is this something we would need for JEP 401's preview/integration?
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2346#discussion_r3129910069
