On Thu, 23 Apr 2026 07:07:45 GMT, Evgeny Nikitin <[email protected]> wrote:

>> Currently JITTester only generates common, instance classes. This PR 
>> suggests a value classes support for the tool.
>> 
>> Specifically, it:
>> - adds a ValueKlass as an AST node carrier for the new type
>> - moves most of KlassFactory internals  into generic AbstractKlassFactory
>> - adds smaller concrete KlassFactory and ValueKlassFactory.
>> - makes sure that we don't generate mutable fields in the value classes
>> - blocks synchronized usage on value-class methods
>> - raises probability to be abstract for the value classes - to check deeper 
>> hierarchies.
>> - adds a parameter governing the balance between instance and value classes. 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Evgeny Nikitin has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Remove 'final' for the value classes
>  - Grammar fix in comment

These changes seem fine from a VM perspective. Thank you! It's probably useful 
to have someone who's knowledgeable on jittester take a look at this in 
addition. And maybe corelibs/langtools wants to as well.

-------------

Marked as reviewed by phubner (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/2346#pullrequestreview-4161440419

Reply via email to