On Wed, 6 May 2026 06:34:33 GMT, David Holmes <[email protected]> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   review: minor test tweaks: more checks, remove unneded code, add a comment 
>> with assumption
>
> src/hotspot/share/prims/jvmti.xml line 13991:
> 
>> 13989:       Virtual machines which are incapable of bytecode instrumentation
>> 13990:       for some or all of their methods can send this event.
>> 13991:       When preview features are enabled and an allocated object has 
>> no identity, the
> 
> Suggestion:
> 
>       When preview features are enabled and an allocated object has no 
> identity,

Thanks, fixed now.

> src/hotspot/share/prims/jvmti.xml line 14086:
> 
>> 14084:       <functionlink id="GetStackTrace"></functionlink>, a user can 
>> track which objects were allocated from which
>> 14085:       stack trace, and which are still live during the execution of 
>> the program.
>> 14086:       When preview features are enabled and an allocated object has 
>> no identity, the
> 
> Suggestion:
> 
>       When preview features are enabled and an allocated object has no 
> identity,

Thanks, fixed now.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2386#discussion_r3194433927
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2386#discussion_r3194442026

Reply via email to