On Wed, 6 May 2026 03:41:28 GMT, Leonid Mesnik <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - review: add explaining comment to new test >> - fix build error in new test on Windows > > test/hotspot/jtreg/serviceability/jvmti/valhalla/VMObjectAllocValue/VMObjectAllocValueTest.java > line 26: > >> 24: /** >> 25: * @test >> 26: * @summary Verifies that a VMObjectAlloc event is generated for object >> created using MethodHandle > > missed 'value' Thanks, fixed now. > test/hotspot/jtreg/serviceability/jvmti/valhalla/VMObjectAllocValue/libVMObjectAllocValueTest.cpp > line 31: > >> 29: >> 30: static jvmtiEnv *jvmti = nullptr; >> 31: // JVMTI_ERROR_WRONG_PHASE guard > > Wonder if this is still needed. No events should be generated after death. > Have you seen that test failed with JVMTI_ERROR_WRONG_PHASE? Good suggestion, thanks. Removed now. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2386#discussion_r3192978576 PR Review Comment: https://git.openjdk.org/valhalla/pull/2386#discussion_r3192971437
