On Wed, 6 May 2026 03:16:46 GMT, Leonid Mesnik <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - review: add explaining comment to new test
>> - fix build error in new test on Windows
>
> test/hotspot/jtreg/serviceability/jvmti/valhalla/SampledObjectAllocValue/SampledObjectAllocValue.java
> line 51:
>
>> 49: public static void main(String[] args) throws Exception {
>> 50: enableEvents(Thread.currentThread(), ValueClass.class);
>> 51: // Allocate value objects to trigger JVMYI SampledObjectAlloc
>> events.
>
> JVMYI -> JVMTI
The test is passing now, however there are a lot of chances that it will fails
once array of 2xlong is made to be flattened.
Might be worth to mention this assumption in the comment also.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2386#discussion_r3192837235
