On Wed, 6 May 2026 03:45:54 GMT, Leonid Mesnik <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - review: add explaining comment to new test
>> - fix build error in new test on Windows
>
> test/hotspot/jtreg/serviceability/jvmti/valhalla/SampledObjectAllocValue/libSampledObjectAllocValue.cpp
> line 58:
>
>> 56: return; // interested in tested value class only
>> 57: }
>> 58: if (object != nullptr) {
>
> I thinks it would be nice to verify the size and klass values. At least not
> nullptr/zero.
Thanks, added the check.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2386#discussion_r3192994453
