On Mon, 1 Jun 2026 16:25:14 GMT, Roland Westrelin <[email protected]> wrote:
>> The bug is caused by a mismatch in the way `LoadFlat` and `StoreFlat` >> are handled in `ConnectionGraph::find_inst_mem()` and >> `MemNode::optimize_simple_memory_chain()`. Once EA has run a first >> time, found some value array allocations as non escaping, and removed >> their `LoadFlat`/`StoreFlat`, igvn runs and is able to further >> transform the memory subgraph which introduces inconsistencies that >> are then caught the next time EA runs. >> >> The fix tries to make sure `ConnectionGraph::find_inst_mem()` and >> `MemNode::optimize_simple_memory_chain()` handle `LoadFlat` and >> `StoreFlat` similarly. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Roland Westrelin has updated the pull request incrementally with one > additional commit since the last revision: > > review src/hotspot/share/opto/escape.cpp line 4624: > 4622: Node* base = proj_in->as_StoreFlat()->base(); > 4623: const TypeOopPtr* t_store_base =igvn->type(base)->is_oopptr(); > 4624: if (t_store_base->instance_id() != toop->instance_id()) { Is it impossible to encounter InstanceBot here? This compare is only valid if both sides are known instances, right? ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2489#discussion_r3337357278
