On Mon, 1 Jun 2026 15:56:21 GMT, Roland Westrelin <[email protected]> wrote:
>> src/hotspot/share/opto/escape.cpp line 4616:
>>
>>> 4614: Node* base = proj_in->as_StoreFlat()->base();
>>> 4615: const TypeOopPtr* t_store_base =igvn->type(base)->is_oopptr();
>>> 4616: if (t_store_base->instance_id() != toop->instance_id()) {
>>
>> A comment explaining what is happening here would be helpful. Why does
>> StoreFlat need this check but LoadFlat does not?
>
> I added some comments. Do they look ok to you?
Yes, the comments help, thanks!
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2489#discussion_r3337360872
