On Mon, 1 Jun 2026 21:45:04 GMT, Dean Long <[email protected]> wrote:
>> Roland Westrelin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review
>
> src/hotspot/share/opto/escape.cpp line 4624:
>
>> 4622: Node* base = proj_in->as_StoreFlat()->base();
>> 4623: const TypeOopPtr* t_store_base =igvn->type(base)->is_oopptr();
>> 4624: if (t_store_base->instance_id() != toop->instance_id()) {
>
> Is it impossible to encounter InstanceBot here? This compare is only valid
> if both sides are known instances, right?
It can nbe `InstanceBot` on the left hand side. AFAIU, `InstanceBot` doesn't
mean any instance, it means any instance other than the ones that are known. So
comparing `InstanceBot` with a known instance returns false as expected.
This said, one problem with this logic is that it gets types from igvn and they
may not have propagated yet. I reworked it to not use the types from igvn.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2489#discussion_r3340996593
