Re: [lworld] RFR: 8385328: [lworld] C2: assert(phi->_idx >= nodes_size()) failed: only new Phi per instance memory slice still happens after JDK-8374742 [v2]

[Roland Westrelin]

On Mon, 1 Jun 2026 21:40:04 GMT, Dean Long <dl...@openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/opto/memnode.cpp line 326:
> 
>> 324:         assert(is_strict_final_load || is_known_instance, "tested 
>> above");
>> 325:         // LoadFlat and StoreFlat cannot happen to strict final fields
>> 326:         // LoadFlat and StoreFlat to known instances are removed at the 
>> end of EA: this one is unrelated
> 
> I asked a particular LLM about this, and it thinks there could be a problem 
> here because a C2_MISMATCHED StoreFlat is not removed, and EA only marks the 
> fields as global escape and not the based object.  Do you agree?

A `StoreFlat` is not a regular `Store` so it can't be `C2_MISMATCHED`.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2489#discussion_r3339235393