On Tue, 16 Jun 2026 12:30:31 GMT, Alan Bateman <[email protected]> wrote:
>> Introduce a `PathResolution` to `ExplodedImage` to remove a lot of ad-hoc >> treatments of preview path discovery. Also some general comments and test >> additions. >> >> One interesting thing is the mainline jimage is not mapping >> `META-INF/preview/file` to `file` when preview is enabled; it does map >> `META-INF/preview/dir/file` to `dir/file`. Don't know if this is intended; >> exploded image performs the first mapping, which differs from jimage. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/java.base/share/classes/jdk/internal/jrtfs/ExplodedImage.java line 149: > >> 147: private byte[] getContent() throws IOException { >> 148: if (!getFileAttributes().isRegularFile()) >> 149: throw new FileSystemException(getName() + " is not a >> resource"); > > The original exception message was correct, it should say "file" or "regular > file". This guy is only called from `SystemImage::getResource`, and the other implementation reports "not a resource" when it fails: https://github.com/openjdk/valhalla/blob/2523a4f43c8d865574693fff3a8944b2c1c64fe8/src/java.base/share/classes/jdk/internal/jimage/ImageReader.java#L788 ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2545#discussion_r3420940686
