On Wed, 17 Jun 2026 10:40:48 GMT, Alan Bateman <[email protected]> wrote:
>> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Review remarks >> - Merge branch 'lworld' of https://github.com/openjdk/valhalla into >> cleanup/lw-jrtfs >> - Cleanup ExplodedImage and enhance SystemImageTest > > test/jdk/jdk/internal/jrtfs/SystemImageTest.java line 113: > >> 111: // Note: somehow this doesn't work for jimage if >> file is in >> 112: // root directory >> 113: "!META-INF/preview/com/two.txt", > > The comment is very confusing. It's just a file that exists only when running > with preview features enabled. > > My preference would be to not include tests that don't work with the run-time > image, let's put them in the JBS issue to re-examine the jimage > implementation. Removed comment, created tracking issue https://bugs.openjdk.org/browse/JDK-8386842 ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2545#discussion_r3429860140
