On Mon, 15 Jun 2026 04:06:11 GMT, Chen Liang <[email protected]> wrote:
> Introduce a `PathResolution` to `ExplodedImage` to remove a lot of ad-hoc > treatments of preview path discovery. Also some general comments and test > additions. > > One interesting thing is the mainline jimage is not mapping > `META-INF/preview/file` to `file` when preview is enabled; it does map > `META-INF/preview/dir/file` to `dir/file`. Don't know if this is intended; > exploded image performs the first mapping, which differs from jimage. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). src/java.base/share/classes/jdk/internal/jrtfs/ExplodedImage.java line 401: > 399: ? (p -> p.startsWith(PREVIEW_DIR) ? > PREVIEW_DIR.relativize(p) : p) > 400: : UnaryOperator.identity(); > 401: try (Stream<Path> contentsStream = Files.walk(moduleDir)) { The re-worked processModuleDirectory looks okay. It could use Files.find to find directories rather than Files.walk and filtering the entries. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2545#discussion_r3421046936
