On Tue, 16 Jun 2026 15:46:20 GMT, Chen Liang <[email protected]> wrote:
>> Introduce a `PathResolution` to `ExplodedImage` to remove a lot of ad-hoc >> treatments of preview path discovery. Also some general comments and test >> additions. >> >> One interesting thing is the mainline jimage is not mapping >> `META-INF/preview/file` to `file` when preview is enabled; it does map >> `META-INF/preview/dir/file` to `dir/file`. Don't know if this is intended; >> exploded image performs the first mapping, which differs from jimage. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains three additional commits since > the last revision: > > - Review remarks > - Merge branch 'lworld' of https://github.com/openjdk/valhalla into > cleanup/lw-jrtfs > - Cleanup ExplodedImage and enhance SystemImageTest src/java.base/share/classes/jdk/internal/jrtfs/ExplodedImage.java line 228: > 226: } > 227: > 228: static final class PathResolution { The naming is a bit awkward, using something like ResolvedPaths would make it easier to read, and would make the field in PathNode easier to understand too. src/java.base/share/classes/jdk/internal/jrtfs/ExplodedImage.java line 333: > 331: > 332: // Ensures this is a name taking form /modules/... with no trailing > slash. > 333: private static boolean isRealPathName(String name) { "real path" has connotations, suggesting it might be testing if the path is a canonicalized path. Something simple isModulesPath is okay or leave it as it was. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2545#discussion_r3427674446 PR Review Comment: https://git.openjdk.org/valhalla/pull/2545#discussion_r3427612463
