On Wed, 1 Jul 2026 18:30:51 GMT, Serguei Spitsyn <[email protected]> wrote:
>> This update is for Valhalla pre-integration. It introduces new JVMTI >> capability `can_support_value_objects`. >> The variable `_can_support_value_objects_count` is introduced for >> optimization. It follows the pattern of the `can_support_virtual_threads` >> capability. >> >> Additionally, this update includes test fixes: >> - >> test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.cpp: >> - Removed the `if (!jni->HasIdentity(object))` check because it is not >> needed anymore as the JVMTI capability `can_support_value_objects` is no >> acquired by the test >> >> - These two tests are updated to provide both positive and negative >> coverage for new capability: >> test/hotspot/jtreg/serviceability/jvmti/valhalla/VMObjectAllocValue >> test/hotspot/jtreg/serviceability/jvmti/valhalla/SampledObjectAllocValue >> >> Testing: >> - Ran updated tests locally >> - Submitted mach5 tiers 1-6 >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Serguei Spitsyn has updated the pull request incrementally with one > additional commit since the last revision: > > review: tweaked spec clarification It's a little unclear to me how this all works when not in preview mode. Does the jvmti client still get to enable can_support_value_objects, but it has no affect. src/hotspot/share/prims/jvmti.xml line 14077: > 14075: JNI local reference to the object that was allocated. > 14076: Null when preview features are enabled, the capability > <code>can_support_value_objects</code> > 14077: is enabled and the allocated object has no identity. Suggestion: is enabled, and the allocated object has no identity. src/hotspot/share/prims/jvmti.xml line 14154: > 14152: JNI local reference to the object that was allocated. > 14153: Null when preview features are enabled, the capability > <code>can_support_value_objects</code> > 14154: is enabled and the allocated object has no identity. Suggestion: is enabled, and the allocated object has no identity. ------------- PR Review: https://git.openjdk.org/valhalla/pull/2607#pullrequestreview-4612085427 PR Review Comment: https://git.openjdk.org/valhalla/pull/2607#discussion_r3508366584 PR Review Comment: https://git.openjdk.org/valhalla/pull/2607#discussion_r3508369437
