On Wed, 1 Jul 2026 09:47:41 GMT, Alan Bateman <[email protected]> wrote:
>> This update is for Valhalla pre-integration. It introduces new JVMTI >> capability `can_support_value_objects`. >> The variable `_can_support_value_objects_count` is introduced for >> optimization. It follows the pattern of the `can_support_virtual_threads` >> capability. >> >> Additionally, this update includes test fixes: >> - >> test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.cpp: >> - Removed the `if (!jni->HasIdentity(object))` check because it is not >> needed anymore as the JVMTI capability `can_support_value_objects` is no >> acquired by the test >> >> - These two tests are updated to provide both positive and negative >> coverage for new capability: >> test/hotspot/jtreg/serviceability/jvmti/valhalla/VMObjectAllocValue >> test/hotspot/jtreg/serviceability/jvmti/valhalla/SampledObjectAllocValue >> >> Testing: >> - Ran updated tests locally >> - Submitted mach5 tiers 1-6 >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/hotspot/share/prims/jvmti.xml line 10718: > >> 10716: When preview features are enabled and this capability is >> enabled, then >> 10717: the following two events are enabled for value object >> allocations: >> 10718: <eventlink id="VMObjectAlloc"></eventlink>, > > "then the following two events are enabled for value object allocations". > This reads a bit like enabling can_support_value_objects will enable these > two events. I think it would be better to say something like "events are sent > for value objects when the following two events are enabled". Thank you for the catch and suggestion. Fixed now. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2607#discussion_r3508167093
