On Wed, 1 Jul 2026 04:46:06 GMT, Serguei Spitsyn <[email protected]> wrote:
>> src/hotspot/share/prims/jvmtiExport.cpp line 3023:
>>
>>> 3021: JvmtiEnvThreadStateIterator it(state);
>>> 3022: for (JvmtiEnvThreadState* ets = it.first(); ets != nullptr; ets =
>>> it.next(ets)) {
>>> 3023: JvmtiEnv *env = ets->get_env();
>>
>> Not related to you fix just general comment for next clean up.
>> It seems that the 'ets' is needed only to get 'env'.
>>
>> So all loop might be rewritten similar to same in the
>> `void JvmtiExport::post_vm_object_alloc(JavaThread *thread, oop object) {`
>> to be
>>
>> `for (JvmtiEnv* env = it.first(); env != nullptr; env = it.next(env)) {`
>
> Thank you for the check. There is the line 3024 which needs the `ets`:
> ` if (ets->is_enabled(JVMTI_EVENT_SAMPLED_OBJECT_ALLOC) &&`
I wonder if it could be done through 'env' like
`env->is_enabled(JVMTI_EVENT_VM_OBJECT_ALLOC)`
?
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2607#discussion_r3507323776
