Igor Lvovsky has posted comments on this change. Change subject: Implement VMs live snapshots ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) Why you need <vmDisk1>? what is it? .................................................... File vdsm/libvirtvm.py Line 1224: except: should it be libvirt specific exception? Line 1233: vmDev = drive.libvirtName() use drive.name I already fixed it my hotplug patchset. It unrelated to whole hotplug feature, so you can push it in :) -- To view, visit http://gerrit.ovirt.org/469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id48a905938037eca2b1de966f4f83d801fdb9970 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
