Igor Lvovsky has posted comments on this change. Change subject: Implement VMs live snapshots ......................................................................
Patch Set 8: (5 inline comments) .................................................... File vdsm/libvirtvm.py Line 1350: for device in self._devices[vm.DISK_DEVICES]: should it be self._devices[vm.DISK_DEVICES][:] ? Don't forget that we can hotplug/hotunplug disk. Hmmm, now when we talking about it. What do you think about interleving snapshot and hotUnplug? Maybe we need some lock here? Line 1358: for device in self._devices[vm.DISK_DEVICES]: self._devices[vm.DISK_DEVICES] [:]? Line 1365: for device in self._devices[vm.DISK_DEVICES]: self._devices[vm.DISK_DEVICES] [:]? Line 1382: for device in self._devices[vm.DISK_DEVICES]: self._devices[vm.DISK_DEVICES][:] ? Line 1392: for device in self.conf["devices"]: self.conf["devices"][:]? -- To view, visit http://gerrit.ovirt.org/469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id48a905938037eca2b1de966f4f83d801fdb9970 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
