Federico Simoncelli has posted comments on this change. Change subject: Implement VMs live snapshots ......................................................................
Patch Set 8: (2 inline comments) .................................................... File vdsm/libvirtvm.py Line 1350: for device in self._devices[vm.DISK_DEVICES]: Let's postpone the lock in a future patch that fixes it for all the invalid combinations (other commands included). Line 1355: return device.name Why should I go through all the devices when I'm looking for a drive? It's the beauty of duplicating the information (grrr!). You can pick what you want according to your personal taste :-) -- To view, visit http://gerrit.ovirt.org/469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id48a905938037eca2b1de966f4f83d801fdb9970 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
