Igor Lvovsky has posted comments on this change.
Change subject: Implement VMs live snapshots
......................................................................
Patch Set 8: (3 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 1355: return device.name
why you are looking for the name in Drive object and not just in
self.conf["devices"]?
Did you filled it in _getUnderlyingDriveInfo?
It's not very important, it just looks me a little odd to compare objects with
dictionaries
Line 1378: self.log.error("Unable to teardown drive: %s",
vmDev)
What about traceback here? Not must, but could be nicer
Line 1393: if device.get("name") == drive["name"]:
self.conf["devices"] consist all devices not only drives.
Maybe compare only drives devices could be nicer:
for dev in self.conf['devices']:
if dev['type'] == vm.DISK_DEVICES and dev.get("name") == drive["name"]
--
To view, visit http://gerrit.ovirt.org/469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id48a905938037eca2b1de966f4f83d801fdb9970
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
