Dan Kenigsberg has posted comments on this change. Change subject: Added new mounting code and integrated into storage_connection ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/mount.py Line 84: rc, out, err = misc.execCmd(cmd) I wouldn't like to have such a nice piece of code using sudo in this way. how about calling a supervdsm.mount function that verifies that the mount point is "ours"? I would very much like to drop the horrible @MOUNT_PATH@, @UMOUNT_PATH@ from our sudoers file. p.s. it is time to flip execCmd's sudo default. -- To view, visit http://gerrit.ovirt.org/543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca58303c13d8d7a4caed4a87b6a16b37651c359 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
