Igor Lvovsky has posted comments on this change. Change subject: Refactor mount logic ......................................................................
Patch Set 5: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/fileSD.py Line 295: mount.getMountFromTarget(self.mountpoint).umount() Saggi, what about oop? Is it redundant now? you explicitly added oop for umount in commit 2ab796e9e5048eb215e80a8b59bfb7e0f3cc34d1. -- To view, visit http://gerrit.ovirt.org/543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca58303c13d8d7a4caed4a87b6a16b37651c359 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
