Igor Lvovsky has posted comments on this change.
Change subject: [WIP] Refactor mount logic
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(7 inline comments)
....................................................
File vdsm/storage/blockSD.py
Line 923: raise
Do we need it twice? you already have it __handleStuckUmount().
....................................................
File vdsm/storage/fileUtils.py
Line 44: NFS_OPTIONS = "".join(config.get('irs', 'nfs_mount_options').split())
Why it still here and not in mount.py ?
....................................................
File vdsm/storage/storage_connection.py
Line 170: mnt.mount(fileUtils.NFS_OPTIONS,
mount.VFS_NFS)
consider to move fileUtils.NFS_OPTIONS to mount.py
Line 177: except se.StorageServerAccessPermissionError, ex:
Remove 'ex' if you don't need it
Line 265: mnt.mount(fileUtils.NFS_OPTIONS,
mount.VFS_NFS)
same question as above
Line 369: self.log.error("Error during storage disconnection:",
exc_info=True)
Probably should be rc = se.StorageServerDisconnectionError.code ?
Line 418: rc = se.StorageException.code
Probably should be rc = se.StorageServerDisconnectionError.code ?
--
To view, visit http://gerrit.ovirt.org/543
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ca58303c13d8d7a4caed4a87b6a16b37651c359
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
