Dan Kenigsberg has posted comments on this change. Change subject: Refactor mount logic ......................................................................
Patch Set 2: I would prefer that you didn't submit this (4 inline comments) .................................................... File vdsm/storage/fuser.py Line 10: (rc, out, err) = misc.execCmd(cmd) pretty please, if you care about the stupid default for sudo, make it explicit .................................................... File vdsm/storage/mount.py Line 47: fs_file = normpath(fs_file) normpath() is not enough to handle funny mountpoints with whitespace or backslash or unprintable chars. Either handle these cases or add a FIXME. Line 72: raise OSError(errno.ENOENT, target) usually the string is more of an English sentence, eg 'mount target %s not found' Line 100: rc, out, err = misc.execCmd(cmd) too bad that you're keeping this as it is, but I understand why. at least be explicit and pass sudo=True. -- To view, visit http://gerrit.ovirt.org/543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca58303c13d8d7a4caed4a87b6a16b37651c359 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
