Dan Kenigsberg has posted comments on this change.

Change subject: drives config normalization.
......................................................................


Patch Set 1: (3 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 1079:             #TODO: Should loop over disks running on the VM.
why?

Line 1084:             for drive in drives:
appears on both branches of the condition!

....................................................
File vdsm/vm.py
Line 458: #    def _initDriveList(self, drives):
why keep this?

--
To view, visit http://gerrit.ovirt.org/624
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80bbd888acc6cccd381f04701c34f52b155e5ca7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to