Dan Kenigsberg has posted comments on this change. Change subject: drives config normalization. ......................................................................
Patch Set 2: I would prefer that you didn't submit this (7 inline comments) .................................................... File vdsm/vm.py Line 340: def __getNextDev(self, used): getNextIndex, probably Line 342: Use only after _usedIndices is filled with the indexed drv's. why? did you mean to s/used/self._usedIndeces/g ? Line 344: for n in range(max(used or [0]) + 2): why +2? if n==max(used)+1 we'd surely break. Line 352: drv['serial'] = drv['imageID'][-20:] again, 'serial' should not be placed in conf. it should be implied in Drive. Line 373: indexed = [] order is irrelevant here, right? if so, use set(). Line 380: self._usedIndices[drv['iface']] = [] how about making this a set() ? Line 382: if index or index == 0: I think that index is not None is clearer -- To view, visit http://gerrit.ovirt.org/624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80bbd888acc6cccd381f04701c34f52b155e5ca7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
