Eduardo has posted comments on this change. Change subject: drives config normalization. ......................................................................
Patch Set 2: (3 inline comments) .................................................... File vdsm/vm.py Line 342: Use only after _usedIndices is filled with the indexed drv's. In order to fill gaps and avoid clashes. Yes, I mean self._usedIndices. Line 344: for n in range(max(used or [0]) + 2): Because range(n+1) returns 0..n and may be you need the next one (n+1), if we are adding an index after the max. Tested offline. Line 373: indexed = [] A list is better for debugging. Provided indices are at the HEAD and a the ones added here are later. And is checked easily too. -- To view, visit http://gerrit.ovirt.org/624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80bbd888acc6cccd381f04701c34f52b155e5ca7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
