Dan Kenigsberg has posted comments on this change. Change subject: drives config normalization. ......................................................................
Patch Set 3: I would prefer that you didn't submit this (3 inline comments) minors only. .................................................... File vdsm/vm.py Line 342: Use only after _usedIndices is filled with the indexed drv's. I still find the docstring confusing. "_usedIndices" is not relevant to this function. "used" is. Line 344: for n in range(max(used or [0]) + 2): oops, I should have understood the +2 on first look ... p.s. I find using xrange() as a better style, even for short loops. Line 371: indexed = [] I don't find the debugability of "list" as a good excuse for making order significant where it is not (and hurting O() complexity while at it) If you feel strongly in favour of "list", you can keep it. For me, its was confusing so please reconsider. -- To view, visit http://gerrit.ovirt.org/624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80bbd888acc6cccd381f04701c34f52b155e5ca7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
