Dan Kenigsberg has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
Gal, the comparison to shutdown shows how much this patch has yet to improve:
* shutdown gives am immediate visible change in the Vm state ("Powering Done").
Currently your patch leaves the Vm in UP until it just dies.
* shutdown ends when the Vm reports exitMessage "User shut down". I think this
would be also the case after this version of guestHibernate, but it SHOULD be
"SaveState succeeded"
* not that shutdown has a timeout - if the Vm still exists after 2 minutes, it
is declared to be Up again.
--
To view, visit http://gerrit.ovirt.org/1121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
