Ayal Baron has posted comments on this change. Change subject: Added a support for a guest hibernate command. ......................................................................
Patch Set 5: (1 inline comment) .................................................... File vdsm/BindingXMLRPC.py Line 330: def vmGuestHibernate(self, vmId, state='disk'): Actually hibernate implies S4, but this function is for both S4 and S3. I agree that vmGuest... is redundant. How about vmSuspend? (S3 is suspend to ram, S4 is suspend to disk). It also complies with Fedora's naming. -- To view, visit http://gerrit.ovirt.org/1121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
