Dan Kenigsberg has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(5 inline comments)
mostly minor comments, thanks!
....................................................
File vdsm/BindingXMLRPC.py
Line 330: def vmGuestHibernate(self, vmId, state='disk'):
What are the acceptable 'state's? What are their meanings?
Hard-coding 'disk' sounds wrong - better define a set of CONSTANTS for them.
Isn't "target" a better name from the arg?
....................................................
File vdsm_cli/vdsClient.py
Line 57: # Guest Hibernate
redspace
Line 59: HIBERNATE_DEFAULT = 'disk'
ok, I see that you define the "states" here, but this have a proper definition
in the server side, too.
....................................................
File vdsm/vm.py
Line 850: return self._shutdownCommand('Powering down', int(timeout),
why int(timeout)?! just to spite me?
Line 854: def hibernate(self, state='disk'):
guestHibernate would be less confusing to me
--
To view, visit http://gerrit.ovirt.org/1121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
